Re: [PATCH 1/1] um: ubd: Fix data corruption

From: Chris Frey
Date: Mon Oct 04 2010 - 15:53:30 EST


On Mon, Oct 04, 2010 at 06:37:36PM +0200, Tejun Heo wrote:
> Hello, sorry about chiming in later. I was off last week.

No problem, I'm eager to test patches to fix this.


> I think we're on the right track. The problem with Jens' patch was
> that it didn't consider the fact that blk_end_request() now internally
> updates the current position of the request, so if restart happens
> after some of part of the request is complete it will end up adding
> the offsets multiple times. I think slightly modifying it to track
> the current position instead of offset should do it. Chris, can you
> please try the following patch and see whether the problem goes away?

Unfortunately, this patch does not fix it for me. I applied your patch
to kernel 2.6.35.5, and got the usual error:

EXT3-fs error (device ubda): ext3_lookup: deleted inode referenced: 566188

Lots of them, actually.

- Chris

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/