Re: [PATCH] serial: ioc3_serial: release resources in error return path
From: Tony Luck
Date: Fri Oct 01 2010 - 16:47:57 EST
On Tue, Sep 28, 2010 at 9:41 PM, Rahul Ruikar <rahul.ruikar@xxxxxxxxx> wrote:
> - goto out4;
> + goto out3;
> - goto out4;
> + goto out3;
you changed *all* uses of out4 to out3, so with this patch I see:
drivers/serial/ioc3_serial.c:2152: warning: label ‘out4’ defined but not used
So I dropped the first hunks, and changed the last one to this:
> out4:
> + for (cnt = 0; cnt < phys_port; cnt++)
> + kfree(ports[cnt]);
> +
> kfree(card_ptr);
> return ret;
Applied with this change.
Thanks
-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/