Re: [PATCH] regulator: max8649 - fix setting extclk_freq

[Mark Brown]

On Fri, Oct 01, 2010 at 01:56:27PM +0800, Axel Lin wrote:
> The SYNC bits are BIT6 and BIT7 of MAX8649_SYNC register.
> pdata->extclk_freq could be [0|1|2].
> (MAX8649_EXTCLK_26MHZ|MAX8649_EXTCLK_13MHZ|MAX8649_EXTCLK_19MHZ)
> It requires to left shift 6 bits to properly set extclk_freq.
> 
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>

Are there existing users of the driver?  It's not always 100% clear if
people are expecting bitfield values that will be shifted in or values
that can be ored directly in.  I don't really mind either way but I'd
rather be careful.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/