Re: [patch 00/47] Sparse irq rework

From: Yinghai Lu
Date: Fri Oct 01 2010 - 01:55:55 EST


On 09/30/2010 04:14 PM, Thomas Gleixner wrote:
> The following patch series cleans up and mostly reimplements the core
> sparse irq implementation and sanitizes the most complex (ab)user:
> arch/x86
>
> The series is based on the previous rework of irq chip functions which
> is available at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git irq/core
>
> A combined throwaway git repository with all the following patches on top of
> tip/irq/core is available at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tglx/linux-2.6-sparse-irq.git
>
> The overall changes are (full changelog below):
> 56 files changed, 1229 insertions(+), 1682 deletions(-)
>
> The series consists of 3 parts:
>
> - cleanup of kernel/irq code and implementation of new allocator
> - conversion of x86 to new irq_chip functions and new allocator
> - trivial cleanup of the remaining users and removal of the old stuff
>
> It's fully bisectable and survived a night of testing in my testfarm.

CC kernel/irq/irqdesc.o
kernel/irq/irqdesc.c:123: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘static’
kernel/irq/irqdesc.c: In function ‘alloc_descs’:
kernel/irq/irqdesc.c:176: error: implicit declaration of function ‘alloc_desc’
kernel/irq/irqdesc.c:176: warning: assignment makes pointer from integer without a cast
kernel/irq/irqdesc.c: In function ‘early_irq_init’:
kernel/irq/irqdesc.c:207: warning: assignment makes pointer from integer without a cast
kernel/irq/irqdesc.c: In function ‘irq_get_next_irq’:
kernel/irq/irqdesc.c:346: error: implicit declaration of function ‘find_next_bit_set’
kernel/irq/irqdesc.c:347: error: implicit declaration of function ‘raw_spin_unlock_irqsave’
kernel/irq/irqdesc.c: In function ‘kstat_irqs_cpu’:
kernel/irq/irqdesc.c:369: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘{’ token
kernel/irq/irqdesc.c:374: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘{’ token
kernel/irq/irqdesc.c:377: error: expected ‘{’ at end of input
make[1]: *** [kernel/irq/irqdesc.o] Error 1

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/