Re: [RESEND PATCH] cpufreq: unnecesary double free inpcc_cpufreq_do_osc

From: Dave Jones
Date: Fri Oct 01 2010 - 01:25:53 EST


On Fri, Oct 01, 2010 at 07:47:23AM +0300, Pekka Enberg wrote:

> > I think Dave's patch is correct. There's a kfree(output.pointer) at line 359.
> > If we fall all the way through without hitting any of the return -ENODEVs,
> > we end up doing a 2nd kfree in the out_free:
>
> There's a second call to acpi_evaluate_object() which takes "output" as
> its argument and allocates more memory.

yup. I merged your patch. after it's soaked in -next for a day, I'll push it to
Linus. (Looks obviously correct, but just being extra careful given where
we are in the release cycle)

Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/