Re: [PATCH 01/34] VFS: Make clone_mnt() and copy_tree() returnerror codes

[Ram Pai]

On Thu, Sep 30, 2010 at 05:33:42PM -0700, Ram Pai wrote:
> On Thu, Sep 30, 2010 at 05:44:18PM -0400, Valerie Aurora wrote:
> > (Resend with correct email for Ram Pai)
> > 
> > On Thu, Sep 30, 2010 at 11:51:30AM +0200, Miklos Szeredi wrote:
> > > On Thu, 16 Sep 2010, Valerie Aurora wrote:
> > > > copy_tree() can theoretically fail in a case other than ENOMEM, but
> > > > always returns NULL which is interpreted by callers as -ENOMEM.
> > > > Convert to return an explicit error.  Convert clone_mnt() for
> > > > consistency and because union mounts will add new error cases.
> > > 
> > > I think it makes sense to push this fix to 2.6.37 independently of the
> > > other patches.
> > > 
> > > Acked-by: Miklos Szeredi <mszeredi@xxxxxxx>
> > 
> > I'm certainly not going to argue, but I spent an hour trying to
> > trigger the non-ENOMEM case (below) and failed - maybe it's
> > unreachable?
> > 
> > > > @@ -1212,11 +1216,12 @@ struct vfsmount *copy_tree(struct vfsmount *mnt, struct dentry *dentry,
> > > >  	struct path path;
> > > >  
> > > >  	if (!(flag & CL_COPY_ALL) && IS_MNT_UNBINDABLE(mnt))
> > > > -		return NULL;
> > > > +		return ERR_PTR(-EINVAL);
> > 
> > Ram, do you remember how this worked?
> 
> Oops. That should be a OR condition. there is one other check in that
> function that should also be a OR condition.

I may be wrong here. Can't exactly recollect what CL_COPY_ALL flag means. Al Viro
might remember?  If CL_COPY_ALL means, to clone everything irrespective of any other
flags, then the above code seems right. 


> 
> BTW: the return value has to be NULL. right? because its not an error
> to clone a unbindable mount. Nor is it an error to not specify CL_COPY_ALL.
> It just means that you want nothing in return.

In any case i think the return value should be NULL.

RP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/