Re: gas 2.16 and assembly macros -- entry_64.S build failure

From: Andrew Morton
Date: Thu Sep 30 2010 - 21:00:29 EST


On Thu, 30 Sep 2010 17:26:13 -0700 "H. Peter Anvin" <hpa@xxxxxxxxx> wrote:

> On 09/16/2010 04:21 AM, Jan Beulich wrote:
> >>
> >> Yes, to only generate CFI on binutils that allows us to write sane
> >> looking code.
> >>
> >> I.e. to disable CONFIG_AS_CFI on binutils that are broken for this.
> >
> > Again - that won't help, as it's the macro invocation that gas
> > fails one, not one of the actual .cfi_* directives.
> >
>
> Looking again at this issue with the binutils version from hell
> (sigh)... I'm running quickly out of ideas.
>
> The problem is that cpp inserts spaces around expansions, so:
>
> pushq_cfi $(USER_DS)
>
> ... turns into something like ...
>
> pushq_cfi $( ( 5 * 8 + 3 ) )
>
> ... which these old versions of gas considers multiple arguments to the
> macro, even though there is no comma anywhere.

Could we run another little program after cpp which takes the spaces
out again?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/