Re: [PATCH 1/2] autofs: Only declare function when CONFIG_COMPAT is defined

From: Geert Uytterhoeven
Date: Thu Sep 30 2010 - 16:37:15 EST


On Thu, Sep 30, 2010 at 22:20, H. Peter Anvin <hpa@xxxxxxxxx> wrote:
> On 09/30/2010 01:00 PM, Geert Uytterhoeven wrote:
>>
>> An alternative (and IMHO better) fix would be to move autofs_root_operations[]
>> and autofs_root_inode_operations[] to the bottom of the file, and get rid of all
>> the forward declarations.
>>
>
> This is a legacy piece of code (autofs3) which has been long since
> obsolete anyway... it's one thing to do a minimal patch to keep it
> alive, another to restructure crap when it's already overdue for removal.

You're right. But please note that autofs4 has the exact same issue.

Gr{oetje,eeting}s,

            Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
             Â Â -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/