Re: [PATCH] DMI to disable Vista compatibility on MSI GX723Notebook

From: Matthew Garrett
Date: Thu Sep 30 2010 - 09:26:22 EST


On Thu, Sep 30, 2010 at 06:44:11PM +0800, Lee, Chun-Yi wrote:
> The brightness control hotkey don't work with Vista compatibility
> , because MSI GX723 included a infinite while loop in DSDT when
> brightness control hotkey pressed.
> MSI GX723 used Nvida video card, the infinite while loop must be a
> workaround with Nvidia's Vista driver.

While this would work, it seems likely that the expected behaviour is
for the graphics driver to call the NVIF method. We don't do that as
yet, but when we do I'm worried about it potentially resulting in this
system being in an unexpected state (NVIF is used, but we don't claim to
be Vista). Can you add a comment indicating that it should be reverted
once nouveau grows support?

--
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/