RE: [PATCH v11 03/17] Add a ndo_mp_port_prep pointer tonet_device_ops.

From: Xin, Xiaohui
Date: Wed Sep 29 2010 - 09:42:43 EST


Ok, I will comment it above the structure.

Thanks
Xiaohui

>-----Original Message-----
>From: Ben Hutchings [mailto:bhutchings@xxxxxxxxxxxxxx]
>Sent: Monday, September 27, 2010 9:43 PM
>To: Xin, Xiaohui
>Cc: netdev@xxxxxxxxxxxxxxx; kvm@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
>mingo@xxxxxxx; davem@xxxxxxxxxxxxx; herbert@xxxxxxxxxxxxxxxxxxxx;
>jdike@xxxxxxxxxxxxxxx
>Subject: Re: [PATCH v11 03/17] Add a ndo_mp_port_prep pointer to net_device_ops.
>
>On Sat, 2010-09-25 at 12:27 +0800, xiaohui.xin@xxxxxxxxx wrote:
>> From: Xin Xiaohui <xiaohui.xin@xxxxxxxxx>
>>
>> If the driver want to allocate external buffers,
>> then it can export it's capability, as the skb
>> buffer header length, the page length can be DMA, etc.
>> The external buffers owner may utilize this.
>[...]
>
>This information needs to be included in the comment above struct
>net_device_ops, not just in the commit message.
>
>Ben.
>
>--
>Ben Hutchings, Senior Software Engineer, Solarflare Communications
>Not speaking for my employer; that's the marketing department's job.
>They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/