Re: [MeeGo-Dev][PATCH v2] Topcliff: Update PCH_GPIO driver to2.6.35

From: Mark Brown
Date: Tue Sep 28 2010 - 13:57:57 EST


On Tue, Sep 28, 2010 at 06:37:57PM +0900, Masayuki Ohtak wrote:

> + gpio->base = (u32)chip->pch_gpio_base_address;

> + chip->reg = chip->pch_gpio_base_address;

The GPIO base passed to gpiolib should be the base GPIO number for the
device, not the address of the control registers. Normally this would
be passed in via platform data or set to -1 to allow the core to assign
a slot.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/