Re: [PATCH v4] power_supply: Add driver for TWL4030/TPS65950 BCIcharger

[Felipe Balbi]

On Tue, Sep 28, 2010 at 06:26:43AM -0500, Anton Vorontsov wrote:
> On Tue, Sep 28, 2010 at 12:41:22PM +0300, Felipe Balbi wrote:
> > On Tue, Sep 28, 2010 at 04:39:17AM -0500, Grazvydas Ignotas wrote:
> > >On Tue, Sep 28, 2010 at 12:06 PM, Felipe Balbi <balbi@xxxxxx> wrote:
> > >>On Tue, Sep 28, 2010 at 04:02:48AM -0500, Grazvydas Ignotas wrote:
> > >>>>
> > >>>>Charger event is SENT by charger driver when it verifies it's attached
> > >>>>to a wall charger.
> > >>>
> > >>>Isn't that a job for musb/gadget? Detecting D+/D- being shorted by
> > >>>charger or something like that? I don't think BCI is able to detect
> > >>>charger.
> > >>
> > >>it's part of the charger detection right ? and according to trm, it's on
> > >>the BCI (actually BCC) role to take care of that :-)
> > >
> > >Hm you are probably talking about TWL5031, which has redesigned
> > >charger block that is named BCC. TWL4030 charger is different, called
> > >BCI and requires software charger detection from what I see in it's
> > >TRM.
> >
> > ok, might be that I got confused. Then it's ok the way it is. So we need
> > other means to detect the charger :-p
>
> May we consider this as a minor issue that can be improved later?

Sure, it's fine.

> If so, I would like to apply it, but I'll wait a day or two for
> Reviewed-by or Acked-by tags to give the proper credits.

Here you go.

Acked-by: Felipe Balbi <balbi@xxxxxx>

--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/