Re: linux-next: build failure after merge of the final tree (net tree related)

[Ohad Ben-Cohen]

On Mon, Sep 27, 2010 at 9:01 PM, Ohad Ben-Cohen <ohad@xxxxxxxxxx> wrote:
> On Mon, Sep 27, 2010 at 8:44 PM, John W. Linville
> <linville@xxxxxxxxxxxxx> wrote:
>> On Mon, Sep 27, 2010 at 08:38:50PM +0200, Ohad Ben-Cohen wrote:
>>> On Mon, Sep 27, 2010 at 8:25 PM, John W. Linville
>>> <linville@xxxxxxxxxxxxx> wrote:
>>> >> BTW, if this fuglet going to work if the driver is built modular?
>>> >>
>>> >> The idea of this things seems to be to allow arch platform code to call
>>> >> into it to set things.  Such calls from arch platform code are going
>>> >> to be "obj-y"
>>> >>
>>> >> So if this is built into the modular driver, I can't see how it
>>> >> can work.
>>> >
>>> > Dave is right -- these Kconfig dependencies (or lack thereof) seem
>>> > to be wrong.
>>>
>>> This is why I had to put it in drivers/net/wireless/Makefile (in both
>>> the original patch and in the fix I sent earlier) and not in
>>> drivers/net/wireless/wl12xx/Makefile (as it was in the fix that Dave
>>> was referring to).
>>>
>>> This way it works with a modular driver.
>>
>> That doesn't seem very helpful if someone selects
>>
>> CONFIG_MACH_OMAP_ZOOM2=y
>> CONFIG_WL12XX_PLATFORM_DATA=n


That's a good point (it's a separate issue); we need to have a select there.

I'll send a patch.

>>
>
> CONFIG_WL12XX_PLATFORM_DATA is selected automatically if the relevant
> driver is selected (this is independent of the underlying arch/board):
>
> config WL12XX_PLATFORM_DATA
>        bool
>        depends on WL1271_SDIO != n
>        default y
>
> All we have to make sure is that it will be compiled built-in. If we
> use drivers/net/wireless/wl12xx/Makefile, and we build a modular
> wl1271_sdio, it won't (despite it being selected as y).
>
> That's why I put it in drivers/net/wireless/Makefile.
>
> In the original patch I put the code itself in
> drivers/net/wireless/wl12xx to make it look nicer, but as Stephen
> reported that seem to break building with a separate object folder...
>
> So the fix I sent just moves that builtin code to
> drivers/net/wireless. This maintains the builtin property even if the
> driver is modular, and fixes the issue reported by Stephen.
>
> Please tell me if you have any thoughts/suggestions.
>
> Thanks,
> Ohad.
>
>> or am I missing something?
>>
>> John
>> --
>> John W. Linville                Someday the world will need a hero, and you
>> linville@xxxxxxxxxxxxx                  might be all we have.  Be ready.
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/