Re: [PATCH 04/24] hwmon: change to new flag variable

From: Valdis . Kletnieks
Date: Mon Sep 27 2010 - 11:04:44 EST


On Fri, 24 Sep 2010 12:17:14 PDT, matt mooney said:
> Replace EXTRA_CFLAGS with ccflags-y.
>
> Signed-off-by: matt mooney <mfm@xxxxxxxxxxxxx>
> ---
> drivers/hwmon/Makefile | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile
> index e3c2484..764b4db 100644
> --- a/drivers/hwmon/Makefile
> +++ b/drivers/hwmon/Makefile
> @@ -109,7 +109,5 @@ obj-$(CONFIG_SENSORS_W83L786NG) += w83l786ng.o
> obj-$(CONFIG_SENSORS_WM831X) += wm831x-hwmon.o
> obj-$(CONFIG_SENSORS_WM8350) += wm8350-hwmon.o
>
> -ifeq ($(CONFIG_HWMON_DEBUG_CHIP),y)
> -EXTRA_CFLAGS += -DDEBUG
> -endif
> +ccflags-$(CONFIG_HWMON_DEBUG_CHIP) := -DDEBUG

Was this series intended as := rather than += as it seems that
overriding the entirely of a passed-in ccflags-y may not be what
we wanted to do.

Attachment: pgp00000.pgp
Description: PGP signature