Re: [PATCH 5/6] conntrack: export lsm context rather than internalsecid via netlink

From: Pablo Neira Ayuso
Date: Mon Sep 27 2010 - 07:01:15 EST


On 24/09/10 22:45, Eric Paris wrote:
@@ -172,4 +173,11 @@ enum ctattr_help {
};
#define CTA_HELP_MAX (__CTA_HELP_MAX - 1)

+enum ctattr_secctx {
+ CTA_SECCTX_UNSPEC,
+ CTA_SECCTX_NAME,
+ __CTA_SECCTX_MAX
+};
+#define CTA_SECCTX_MAX (__CTA_SECCTX_MAX - 1)

I guess that you have included this nest for consistency with CTA_HELP. My question: do you think that we'll include more attributes in that nest in the future? Otherwise, I would remove that nest and put CTA_SECCTX_NAME in the first level, since the nest would increase the message size.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/