Re: [PATCH 5/5] ACPI, APEI, Fix ERST MOVE_DATA instruction implementation

From: Andi Kleen
Date: Mon Sep 27 2010 - 01:31:20 EST


> In my test machine, MOVE_DATA is not used. So this does not breaks
> serialization of machine checks.

Ok. But we don't know what other systems are doing.
>
> We can not use kmap_atomic or kmap_atomic_pfn here. Because
> kmap_atomic_xxx needs struct page, but the address provided by BIOS
> may be in E820_RESERVED area, that is, the corresponding page may have
> no struct page. Maybe we need another kmap_atomic implementation for
> E820_RESERVED area.

Yes, at some point that may be needed.

It would be good to have some kind of warning that gets reported
back to us when this happens. This should happen on panicing situations
anyways, so we can printk.

-Andi

--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/