Re: [PATCH] PCI / PCIe / AER: Disable native AER service if BIOShas precedence (v2) (was: Re: [PATCH] PCI / PCIe / AER ...)

From: Huang Ying
Date: Sat Sep 25 2010 - 01:51:40 EST


Hi, Rafael,

On Tue, 2010-09-21 at 00:50 +0800, Rafael J. Wysocki wrote:
> --- linux-2.6.orig/drivers/pci/pcie/portdrv_acpi.c
> +++ linux-2.6/drivers/pci/pcie/portdrv_acpi.c
> @@ -49,7 +49,7 @@ int pcie_port_acpi_setup(struct pci_dev
> | OSC_PCI_EXPRESS_PME_CONTROL;
>
> if (pci_aer_available()) {
> - if (pcie_aer_get_firmware_first(port))
> + if (aer_acpi_firmware_first())
> dev_dbg(&port->dev, "PCIe errors handled by BIOS.\n");
> else
> flags |= OSC_PCI_EXPRESS_AER_CONTROL;

The original per-device firmware_first is overridden by the new global
firmware_first? If it is, why keep the original per-device
firmware_first?

Best Regards,
Huang Ying


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/