Re: [RFC][Patch] IBM Real-Time "SMI Free" mode driver -v5

[Randy Dunlap]

On Fri, 24 Sep 2010 14:30:09 -0700 Vernon Mauery wrote:

> >> +/* The RTL table as presented by the EBDA: */
> >> +struct ibm_rtl_table {
> >> +	char signature[5];
> >
> >Question:  are all 5 bytes of signature[] used?  It looks like the search code
> >only checks for 32 bits of signature (and the last byte can be garbage?).
> 
> Technically, the 5 bytes are supposed to be "_RTL_", but it is a lot 
> easier to just check _RTL since we can do that with a single read.  I 
> suppose I could do a 64-bit read and mask the bits that matter.  Do you 
> have an opinion on the matter?

I would just comment that the first 4 bytes are checked.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/