Re: [usb-storage] [PATCH 23/24] usb: change to new flag variable

[Matthew Dharm]

On Fri, Sep 24, 2010 at 12:17:33PM -0700, matt mooney wrote:
> Replace EXTRA_CFLAGS with ccflags-y.

> diff --git a/drivers/usb/storage/Makefile b/drivers/usb/storage/Makefile
> index ef7e5a8..786f086 100644
> --- a/drivers/usb/storage/Makefile
> +++ b/drivers/usb/storage/Makefile
> @@ -5,7 +5,7 @@
>  # Rewritten to use lists instead of if-statements.
>  #
>  
> -EXTRA_CFLAGS	:= -Idrivers/scsi
> +ccflags-y	:= -Idrivers/scsi
>  
>  obj-$(CONFIG_USB_STORAGE)	+= usb-storage.o

I don't really know anything about the new 'ccflags' stuff.. but my
instincts tell me that perhaps that should be
'ccflags-$(CONFIG_USB_STORAGE)' rather than 'ccflags-y'?

Does it make a difference that usb-storage can be built-in or a loadable
module?

Matt

-- 
Matthew Dharm                              Home: mdharm-usb@xxxxxxxxxxxxxxxxxx 
Maintainer, Linux USB Mass Storage Driver

I could always suspend a few hundred accounts and watch what happens.
					-- Tanya
User Friendly, 7/31/1998

Attachment: pgp00000.pgp
Description: PGP signature