Re: Dynamic Debug module.ddebug fake param enhancements V4

From: Bjorn Helgaas
Date: Fri Sep 24 2010 - 10:58:15 EST


On Friday, September 24, 2010 06:28:27 am Thomas Renninger wrote:
> The patches are intended for Greg's tree and depend on 3 other
> dynamic debug patches which already are in linux-next, but not in
> the vanilla kernel yet.
>
> [PATCH 1/4] Dynamic Debug: Introduce global fake module param module.ddebug - V4
> V3 -> V4: Do not put that large arrays on the stack, make one func __init
>
> [PATCH 2/4] PNP: Compile all pnp built-in stuff in one module namespace
> [PATCH 3/4] PNP: Use dev_dbg instead of dev_printk(KERN_DEBUG.. if DYNAMIC_DEBUG is compiled in
> -> Compile PNP subsystem in a separate pnp module namespace
>
> [PATCH 4/4] kernel/module.c: Fix compiler warnings if debug is compiled in
> -> minor compile fixup
>
> Only the two PNP patches really belong together.
> If someone e.g. complains about the PNP patches, please still submit the rest.

I confess that I don't understand the objective here (only because
I haven't taken enough time to read and understand the patches).

Some examples of how you expect to use this would probably help me
understand. And if you can compare that with the current, more
difficult way, that would be even better.

I don't know if it's relevant, but I plan to change some of the
pnp_dbg() uses to dev_printk(KERN_DEBUG). Specifically, mainline
already logs all PCI device BARs with KERN_DEBUG, so that information
is always in dmesg. PNP currently uses pnp_dbg() for the corresponding
ACPI device resource usage, so to get that information, I often have
to request another boot with CONFIG_PNP_DEBUG_MESSAGES=y and "pnp.debug".
I want to convert those resource messages to dev_printk(KERN_DEBUG) so
they're just always in dmesg.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/