Re: Potential race in irq_chip_set_defaults()?

From: Thomas Gleixner
Date: Fri Sep 24 2010 - 04:45:24 EST


Jeremy

On Thu, 23 Sep 2010, Jeremy Fitzhardinge wrote:

> irq_chip_set_defaults() modifies the irq_chip structure in-place when
> setting up an irq. If that happens on multiple CPUs at once then it
> could leave the irq_chip structure in an inconsistent state.
>
> Is there anything preventing that case from happening? There's no
> locking, and as far as I know there's no rule forbidding concurrent
> calls to set_irq_chip()/irq_chip_set_defaults().

that's true. Never thought about that. Will have a look.

Thanks,

tglx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/