Re: [PATCH v2] lis3: Add support for new LIS3DC / HP3DC chip

[Takashi Iwai]

At Thu, 23 Sep 2010 12:43:13 -0700,
Andrew Morton wrote:
> 
> On Thu, 23 Sep 2010 08:01:31 +0200
> Takashi Iwai <tiwai@xxxxxxx> wrote:
> 
> > A new version of LIS3 chip has slight incompatibilities from former
> > versions.  This patch adds the minimal support for it.
> > 
> > Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
> > ---
> > v1->v2
> >   Rebased to patch "lis3: Fix Oops with NULL platform data (v2)"
> > 
> 
> Wait.  I did my own rebasing and came up with a different patch, with
> two extra hunks:
> 
> @@ -301,8 +311,9 @@ static irqreturn_t lis302dl_interrupt(in
>  	wake_up_interruptible(&lis3_dev.misc_wait);
>  	kill_fasync(&lis3_dev.async_queue, SIGIO, POLL_IN);
>  out:
> -	if (lis3_dev.pdata && lis3_dev.whoami == WAI_8B && lis3_dev.idev &&
> -	    lis3_dev.idev->input->users)
> +	if (lis3_dev.pdata &&
> +		(lis3_dev.whoami == WAI_8B || lis3_dev.whoami == WAI_3DC) &&
> +		lis3_dev.idev && lis3_dev.idev->input->users)
>  		return IRQ_WAKE_THREAD;
>  	return IRQ_HANDLED;
>  }
> 
> and
> 
> @@ -742,7 +762,7 @@ int lis3lv02d_init_device(struct lis3lv0
>  	 * io-apic is not configurable (and generates a warning) but I keep it
>  	 * in case of support for other hardware.
>  	 */
> -	if (dev->pdata && dev->whoami == WAI_8B)
> +	if (dev->pdata && (dev->whoami == WAI_8B || dev->whoami == WAI_3DC))
>  		thread_fn = lis302dl_interrupt_thread1_8b;
>  	else
>  		thread_fn = NULL;
> 
> 
> Did you drop those changes deliberately?

IMO, safer to drop these, so far.
For platform-specific, the driver requires the initialization of some
registers, and currently it's only for WAI_8B chips.  WAI_3DC has
incompatibilities and cannot use it as is.


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/