Re: [PATCH 3/3] VFIO V4: VFIO driver: Non-privileged user level PCI drivers

From: Tom Lyon
Date: Thu Sep 23 2010 - 15:43:21 EST


On Thursday, September 23, 2010 05:58:01 am Andy Walls wrote:

> Hi Tom,
>
> pci_iomap() can possibly return NULL here and also in
> vfio_mem_readwrite(). Even if there are no security implications
> (unintended access to low I/O ports?), I think you still have potential
> for an Oops in the code below.
>
> ... unless there's a reason why pci_iomap() can't possibly return NULL
> in these instances. Maybe I'm missing something.
>
> Regards,
> Andy

Thanks for the catch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/