Re: [PATCH] fsldma: move DMA_SLAVE support functions to the driver

[Dan Williams]

On Tue, Sep 7, 2010 at 1:45 PM, Ira W. Snyder <iws@xxxxxxxxxxxxxxxx> wrote:
> The DMA_SLAVE support functions all existed as static inlines in the
> driver specific header arch/powerpc/include/asm/fsldma.h. Move the body
> of the functions to the driver itself, and EXPORT_SYMBOL_GPL() them.
>
> At the same time, add the missing linux/list.h header.
>
> Signed-off-by: Ira W. Snyder <iws@xxxxxxxxxxxxxxxx>
> ---
>
> Hello AKPM, Dan,

Hi, I'm back from paternity leave.

>
> At AKPM's request, I moved these static inline'd functions into the driver
> code itself, and then EXPORT_SYMBOL_GPL()'d them. I also added a gfp
> parameter to the fsl_dma_slave_alloc() function. And included the
> linux/list.h header.
>
> If you'd like three separate patches, I can do that. The changes were so
> trivial that I lumped all of them into a single patch.
>
> Thanks,
> Ira
>
>  arch/powerpc/include/asm/fsldma.h |   70 +++------------------------------
>  drivers/dma/fsldma.c              |   77 +++++++++++++++++++++++++++++++++++++

Remind me why we need this header file and these routines again?  git
grep says nothing in-tree is using these?

I also do not want to proliferate driver specific interfaces.  It
defeats the purpose of having a common dmaengine structure.  Along
these lines Linus W. added the new device_control() method (first
added in commit c3635c78, later tweaked in 05827630).  Could that be
massaged for your needs?

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/