Re: [PATCH tip/core/rcu 5/8] rcu: only one evaluation of arg inrcu_dereference_check() unless sparse

[Paul E. McKenney]

On Thu, Sep 23, 2010 at 03:13:39PM +0200, Arnd Bergmann wrote:
> On Thursday 23 September 2010, Paul E. McKenney wrote:
> > The current version of the __rcu_access_pointer(), __rcu_dereference_check(),
> > and __rcu_dereference_protected() macros evaluate their "p" argument
> > three times, not counting typeof()s.  This is bad news if that argument
> > contains a side effect.  This commit therefore evaluates this argument
> > only once in normal kernel builds.  However, the straightforward approach
> > defeats sparse's RCU-pointer checking, so when __CHECKER__ is defined,
> > the additional pair of evaluations of the "p" argument are performed in
> > order to permit sparse to detect misuse of RCU-protected pointers.
> > 
> > Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> > Cc: Arnd Bergmann <arnd@xxxxxxxx>
> 
> Sorry for not following up with the alternative approach yet. We can always
> do that later, for your patch should go into 2.6.36 to fix any problems
> arising from unintended macro side-effects.
> 
> Acked-by: Arnd Bergmann <arnd@xxxxxxxx>

No problem, when you get me a better approach, I will happily queue it!

							Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/