Re: [PATCH] perf build fixes for opensuse 10.0

[John Kacur]

On Wed, Sep 22, 2010 at 1:15 PM, Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
>> On Wed, Sep 22, 2010 at 11:03 AM, Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
>>> Fix the perf Makefile to compile on opensuse 10.0
>>>
>>> -Werror in shipping code is usually a bad idea. Remove that.
>>
>> Why not remove it then when you ship the code, but leave it in the kernel
>> where it is useful?
>
> What do you mean with "you ship"?

The subject of your email is "perf build fixes for opensuse 10.0"
So, I inferred from there.

> I downloaded a kernel from kernel.org, it shipped to me and didn't
> build.

Any reason you can't fix the build errors instead?
Btw, I just tried building the lastest perf in tip/master
and I had no problems.

>
> People can enable -Werror in their private source dirs, but
> it shouldn't be in any downloadable tarball or git.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/