Re: [PATCH 03/10] jump label v11: base patch

From: H. Peter Anvin
Date: Tue Sep 21 2010 - 13:36:49 EST


On 09/21/2010 08:14 AM, Steven Rostedt wrote:
>>
>>> Also, I think the hash table deals nicely with modules.
>>
>> Maybe but it's also a lot of code. And it seems to me
>> that it is optimizing the wrong thing. Simpler is nicer.
>
> I guess simplicity is in the eye of the beholder. I find hashes easier
> to deal with than binary searching sorted lists. Every time you add a
> tracepoint, you need to resort the list.
>
> Hashes are much easier to deal with and scale nicely. I don't think
> there's enough rational to switch this to a binary list.
>

If all you need is exact matches -- as in this case -- hashes are
generally faster than binary anyway.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/