Re: [PATCH 4/5] ACPI, APEI, Fix error path for memory allocation

[Andi Kleen]

On Sun, Sep 19, 2010 at 11:00:34AM +0800, Huang Ying wrote:
> @@ -475,7 +479,13 @@ int apei_resources_request(struct apei_resources *resources,
>  		}
>  	}
>  
> -	apei_resources_merge(&apei_resources_all, resources);
> +	rc = apei_resources_merge(&apei_resources_all, resources);
> +	if (rc) {
> +		pr_err(APEI_PFX
> +"Error in APEI internal resource management, there may be inconsistent "
> +"between APEI internal and system resource management.");

Please fix the English. This will wrap in the syslog without \ns no?
Kernel messges should be not wider than 80 characters.

> +	rc = apei_resources_sub(&apei_resources_all, resources);
> +	if (rc)
> +		pr_err(APEI_PFX
> +"Error in APEI internal resource management, there may be inconsistent "
> +"between APEI internal and system resource management.");

Same.

Also instead of Error it would be better just say what is wrong and don't
try to analyze the problem.

-Andi
-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/