Re: [PATCH] oprofile: Add Support for Intel CPU Family 6 / Model 29

[Arnd Bergmann]

On Tuesday 21 September 2010, Jiri Olsa wrote:
> --- a/arch/x86/oprofile/nmi_int.c
> +++ b/arch/x86/oprofile/nmi_int.c
> @@ -674,6 +674,7 @@ static int __init ppro_init(char **cpu_type)
>         case 0x0f:
>         case 0x16:
>         case 0x17:
> +       case 0x1d:
>                 *cpu_type = "i386/core_2";
>                 break;
>         case 0x1a:

Just curious about the other missing IDs: this now supports all Core
microarchitecture CPUs, but only some Nehalem/Westmere ones.

There is support for 0x1a (Bloomfield/Gainestown) and 0x2e (Beckton), but
not for the much more common 0x1e (Lynnfield/Clarksfield/Jasper Forest),
0x25 (Clarkdale/Arrandale) and 0x26 (Gulftown/Westmere-EP).

Shouldn't those be added as well?

When you're there, it probably also wouldn't hurt to fill in the blanks
of some of the older CPUs like Tolopai (0x15) and newer Atoms (0x1c).

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/