Re: [PATCH] scripts/get_maintainer.pl: fix .mailmap handling

[Joe Perches]

On Tue, 2010-09-21 at 06:59 +0200, Florian Mickler wrote:
> Come on, Joe! It was "sub mailmap" before. @addresses was @list before
> and @ret is the list that get's returned by the function. 

Tell me, what's better as an individual line in perl
with typeless returns
	return @ret;
or
	return @list;

@ret is not descriptive.
Yeah, it's an array.
An array of what?
btw: @list was sub-optimal too.

> If you think a patch is ok, you actually may say so. 

As we discussed privately, yes, .mailmap handling was broken
but both of us seem to think that it's not even necessary as
most .mailmap entries are created manually and it's not
up-to-date.  Name de-duplication is more effective.

.mailmap could be used effectively I suppose, but I asked you
to show a use case where it performs differently than the
existing name de-duplication.

And, I do ack a patch after I think it is ready to be applied.
Until then, I note what I see as shortcomings and defects.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/