Re: [PATCH 0/7 v3] overlay filesystem prototype

From: Neil Brown
Date: Mon Sep 20 2010 - 21:31:17 EST


On Mon, 20 Sep 2010 20:04:04 +0200
Miklos Szeredi <miklos@xxxxxxxxxx> wrote:

> Here's an updated patch series.
>
> For now I reverted Neil's revalidation patch. Not requiring strict
> read-only would make sense for just trying it out and experimenting.
> But for real uses, I'm not sure...

:-)

I think you significantly reduce the value by insisting on read-only but as
this is purely a theoretical perspective at the moment (I have no concrete
use-case) I won't push it.

I had another patch I was working on which caused overlayfs to keep negative
dentries in upperdentry or lowerdentry rather than just setting them to
NULL. This would allow revalidation to notice objects appearing in the
underlying filesystem. I guess you won't want that now .... I think it made
some of the code a bit neater, but I never finished it so I cannot be sure of
the overall effect.

I'm curious as to why upperdentry is now called __upperdentry - it isn't
clear from a quick reading..

Thanks,
NeilBrown

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/