Re: [PATCH] scripts/get_maintainer.pl: fix .mailmap handling

[Joe Perches]

On Tue, 2010-09-21 at 00:35 +0200, florian@xxxxxxxxxxx wrote:
> From: florian@xxxxxxxxxxx <florian@xxxxxxxxxxx>
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl

[]

> -	my ($name, $address) = parse_email($line);
> -	$line = format_email($name, $address, $email_usename);
> +	next if (/^\s*$/); #skip empty lines
> +	#print "entry: \"$_\"\n";

Please do not add commented out debugging code.
Add and use use some centralized debug(foo) call.

[]

> +sub mailmap {
> +    my (@addresses) = @_;
> +
> +    my @ret = ();

Suboptimal naming.  I try to use descriptive names.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/