Re: [PATCH] drm/sysfs: Provide per connector control of DRM KMSpolling

[Greg KH]

On Mon, Sep 20, 2010 at 08:59:00AM -0400, Andy Walls wrote:
> DRM KMS polling of connections providing errant EDID responses, or
> polling of "connectors" that have chips responding on DDC I2C bus
> address 0xA0/0xA1 with no actual physical connector nor EDID EEPROM,
> will create perpetual noise in dmesg and the system log every 10
> seconds.  Currently the user has apparently little recourse to silence
> these messages aside from replacing the offending cable, monitor, or
> graphics adapter.  That recourse is impossible for an unused DVI-D
> "connector" of an internal graphics processor on a motherboard that
> provides no physical DVI-D connector.
> 
> This change allows the root user to disable (and re-enable) DRM KMS
> connector polling on a per connector basis via sysfs, like so:
> 
>         # cat /sys/class/drm/card0/card0-DVI-D-1/polled
>         [hotplug_detectable] connect disconnect
>         
>         # echo > /sys/class/drm/card0/card0-DVI-D-1/polled
>         # cat /sys/class/drm/card0/card0-DVI-D-1/polled
>         hotplug_detectable connect disconnect
>         
>         # echo " connect  hotplug_detectable " > \
>         	/sys/class/drm/card0/card0-DVI-D-1/polled
>         # cat /sys/class/drm/card0/card0-DVI-D-1/polled
>         [hotplug_detectable] [connect] disconnect
>         
>         # echo > /sys/class/drm/card0/card0-DVI-D-1/polled
>         # cat /sys/class/drm/card0/card0-DVI-D-1/polled
>         hotplug_detectable connect disconnect
> 
> with the enabled poll types for the connector denoted in brackets: [].
> This allows the root user to silence DRM KMS log spam for locally known
> uncorrectable conditions.
> 
> Signed-off-by Andy Walls <awalls@xxxxxxxxxxxxxxxx>

You are adding a sysfs file, yet you forgot to add a file in
Documentation/ABI.  Please fix that and resend the patch.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/