Re: [PATCH] net: core: dev.c: use spin_lock_irqsave() rather than

From: MichaÅ Nazarewicz
Date: Mon Sep 20 2010 - 13:46:57 EST


On Mon, 20 Sep 2010 18:03:41 +0200, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:
dev_get_stats(dev, &temp) is called from drivers/usb/gadget/rndis.c,
while I suspect underlying stats are already provided in dev->stats

So, you are saying that it is likely that if I change rndis.c and replace
"dev_get_stats(net, &temp)" with plain "&net->stats" things should work
correctly (rndis.c does not use the "temp" so it's not a problem)?

I actually did that and nothing seems to crash but dunno if it didn't
make g_ether report some not fully up-to-date values or something.

--
Best regards, _ _
| Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o
| Computer Science, MichaÅ "mina86" Nazarewicz (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/