Re: A simple question of sys_

[AmÃrico Wang]

On Fri, Sep 17, 2010 at 02:58:30PM +0800, Rofail Qu wrote:
>How to use macro IS_ERR() ?
>
>It defines as,
>...
>#define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO)
>static inline long __must_check IS_ERR(const void *ptr)
>{
>	return IS_ERR_VALUE((unsigned long)ptr);
>}
>...
>so when pass x as a pointer and x>=-MAX_ERRNO (including NULL or any
>valid address),
>IS_ERR() will return true!

NULL is not an error pointer, you missed the cast to unsigned long.


>IS_ERR(x) seems to use on judge if "x" is a valid error number, right?
>

Strictly speaking, it checks if 'x' is an error pointer.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/