Re: [PATCH 10/14] scsi: osd: fix device_register() error handling

From: Dan Carpenter
Date: Sun Sep 19 2010 - 11:13:22 EST


On Sun, Sep 19, 2010 at 06:39:50PM +0400, Vasiliy Kulikov wrote:
> >
> > If that's the case then the put_device() should be called infront of the
> > goto.
>
> As it is the last call that may fail, it is redundant. Or you mean for future,
> if someone adds more code after device_register()?
>

Yes. I mean in the future.

regards,
dan carpenter

>
> Thanks,
> --
> Vasiliy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/