Re: [PATCH v2] dell-laptop: Add debugfs support

[Keng-YÃ Lin]

On Fri, Sep 17, 2010 at 12:46 AM, Len Brown <lenb@xxxxxxxxxx> wrote:
>
>> +#ifdef CONFIG_DEBUG_FS
>
> Looks like you can delete these.
>
> Of course you'd want to properly check the return value
> from debugfs_create_dir(), which returns an ERR_PTR
> when CONFIG_DEBUG_FS is not defined. (even though
> few in the kernel seem to be bothering to use IS_ERR() here.)
>
> cheers,
> Len Brown, Intel Open Source Technology Center
>

Hi Len:
  If CONFIG_DEBUG_FS is not defined, all debugfs_create_dir(),
debugfs_create_file() and debugfs_remove_recursive() here will just
return -ENODEV. I think in this case, it causes little harm just to
skip checking the return value with IS_ERR() since no follow-up action
for that.

  Regards,
-kengyu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/