Re: [PATCH v2] drivers/net/tulip/de4x5.c

From: David Miller
Date: Fri Sep 17 2010 - 00:53:03 EST


From: Dan Rosenberg <drosenberg@xxxxxxxxxxxxx>
Date: Wed, 15 Sep 2010 17:43:18 -0400

> Fixed formatting (tabs and line breaks).
>
> This was previously reported as a security issue due to leakage of
> uninitialized stack memory. Jeff Mahoney pointed out that this is
> incorrect since the copied data is from a union (rather than a struct).
> Therefore, this patch is only under consideration for the sake of
> correctness, and is not security relevant.
>
> Signed-off-by: Dan Rosenberg <dan.j.rosenberg@xxxxxxxxx>
> Acked-by: Grant Grundler <grundler@xxxxxxxxxxxxxxxx>

You need to give something more descriptive than just the name of the
file you're editing in the Subject: line of this commit message.

Otherwise people scanning "shortlog" and similar output won't have
even a general idea of what kind of change your commit is making.

Please formally resubmit this with a proper commit header line.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/