Re: [MeeGo-Dev][PATCH v2] Topcliff: Update PCH_CAN driver to 2.6.35

From: Masayuki Ohtake
Date: Thu Sep 16 2010 - 19:56:18 EST


Hi Wolfgang Grandegger

According to your policy, we will remove filter processing so that
all packets can be received.

Thanks, Ohtake(OKISemi)
----- Original Message -----
From: "Wolfgang Grandegger" <wg@xxxxxxxxxxxxxx>
To: "Masayuki Ohtake" <masa-korg@xxxxxxxxxxxxxxx>
Cc: "Marc Kleine-Budde" <mkl@xxxxxxxxxxxxxx>; <arjan@xxxxxxxxxxxxxxx>; "Tomoya MORINAGA" <morinaga526@xxxxxxxxxxxxxxx>;
<yong.y.wang@xxxxxxxxx>; <gregkh@xxxxxxx>; <qi.wang@xxxxxxxxx>; <andrew.chih.howe.khor@xxxxxxxxx>;
<meego-dev@xxxxxxxxx>; <linux-kernel@xxxxxxxxxxxxxxx>; <netdev@xxxxxxxxxxxxxxx>; <socketcan-core@xxxxxxxxxxxxxxxx>;
"Samuel Ortiz" <sameo@xxxxxxxxxxxxxxx>; "Barry Song" <21cnbao@xxxxxxxxx>; "Christian Pellegrin" <chripell@xxxxxxxx>;
"Wolfram Sang" <w.sang@xxxxxxxxxxxxxx>; "David S. Miller" <davem@xxxxxxxxxxxxx>
Sent: Thursday, September 16, 2010 6:10 PM
Subject: Re: [MeeGo-Dev][PATCH v2] Topcliff: Update PCH_CAN driver to 2.6.35


> On 09/16/2010 10:51 AM, Masayuki Ohtake wrote:
> > Hi Marc,
> >
> >> - Please remove rx-filter handling from the driver completely, simply
> >> receive every can frame
> >
> > This rx-filter function is for Topcliff's CAN HW function.
> > This function is important.
> > Could you tell us the reason why should we remove filter function ?
>
> We do not (yet) support the filtering capability of the CAN controller
> hardware. Therefore please configure the hardware filter to accept *any*
> CAN message like all other drivers do, e.g.:
>
> http://lxr.linux.no/#linux+v2.6.35.4/drivers/net/can/sja1000/sja1000.c#L249
>
> Wolfgang.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/