[PATCH 08/12] BKL: Remove BKL from afs

From: Arnd Bergmann
Date: Thu Sep 16 2010 - 13:48:09 EST


The BKL is only used in put_super and fill_super, which are both protected
by the superblocks s_umount rw_semaphore. Therefore it is safe to remove
the BKL entirely.

Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Cc: linux-afs@xxxxxxxxxxxxxxxxxxx
Cc: David Howells <dhowells@xxxxxxxxxx>
---
fs/afs/super.c | 10 ----------
1 files changed, 0 insertions(+), 10 deletions(-)

diff --git a/fs/afs/super.c b/fs/afs/super.c
index 6c2fef4..eacf76d 100644
--- a/fs/afs/super.c
+++ b/fs/afs/super.c
@@ -19,7 +19,6 @@
#include <linux/mount.h>
#include <linux/init.h>
#include <linux/slab.h>
-#include <linux/smp_lock.h>
#include <linux/fs.h>
#include <linux/pagemap.h>
#include <linux/parser.h>
@@ -302,15 +301,12 @@ static int afs_fill_super(struct super_block *sb, void *data)
struct inode *inode = NULL;
int ret;

- lock_kernel();
-
_enter("");

/* allocate a superblock info record */
as = kzalloc(sizeof(struct afs_super_info), GFP_KERNEL);
if (!as) {
_leave(" = -ENOMEM");
- unlock_kernel();
return -ENOMEM;
}

@@ -344,7 +340,6 @@ static int afs_fill_super(struct super_block *sb, void *data)
sb->s_root = root;

_leave(" = 0");
- unlock_kernel();
return 0;

error_inode:
@@ -358,7 +353,6 @@ error:
sb->s_fs_info = NULL;

_leave(" = %d", ret);
- unlock_kernel();
return ret;
}

@@ -458,12 +452,8 @@ static void afs_put_super(struct super_block *sb)

_enter("");

- lock_kernel();
-
afs_put_volume(as->volume);

- unlock_kernel();
-
_leave("");
}

--
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/