Re: [PATCH 1/2] hwmon: (adm1031) Replace update_rate sysfsattribute with update_interval

[Guenter Roeck]

On Thu, Sep 16, 2010 at 11:14:43AM -0400, Jean Delvare wrote:
> On Wed, 15 Sep 2010 19:07:14 -0700, Guenter Roeck wrote:
> > The attribute reflects an interval, not a rate.
> > 
> > Signed-off-by: Guenter Roeck <guenter.roeck@xxxxxxxxxxxx>
> > ---
> >  Documentation/hwmon/sysfs-interface |   12 +++++-----
> >  drivers/hwmon/adm1031.c             |   43 +++++++++++++++++++---------------
> >  2 files changed, 30 insertions(+), 25 deletions(-)
> > 
> > diff --git a/Documentation/hwmon/sysfs-interface b/Documentation/hwmon/sysfs-interface
> > index ff45d1f..df0cdd2 100644
> > --- a/Documentation/hwmon/sysfs-interface
> > +++ b/Documentation/hwmon/sysfs-interface
> > @@ -91,13 +91,13 @@ name		The chip name.
> >  		I2C devices get this attribute created automatically.
> >  		RO
> >  
> > -update_rate	The rate at which the chip will update readings.
> > -		Unit: millisecond
> > +update_interval	The interval at which the chip or driver will update readings.
> 
> I think I prefer the original wording. The attribute is really about
> setting the register refresh rate at the hardware level. The fact that
> register cache lifetime in the driver can be adjusted accordingly is an
> optional implementation detail IMHO.
> 
Ok, no problem.

> > +		Unit: milliseconds
> 
> Why change? All other units are singular in the file.
> 
Correct for anything but "milliseconds".

I changed it to milliseconds because all other attributes specify
"milliseconds". No other reason. Am I missing something ?

> >  		RW
> > -		Some devices have a variable update rate. This attribute
> > -		can be used to change the update rate to the desired
> > -		frequency.
> > -
> 
> Killing an innocent blank line ;)
> 
Just trying to sneak it through. Got me there.

> > +		Some devices have a variable update rate or interval.
> > +		Some drivers may want to make the update interval configurable
> > +		instead of using a hardcoded value. This attribute can be used
> > +		to change the update interval to the desired value.
> >  
> > +           instead of using a hardcoded value." 
> >  ************
> >  * Voltages *
> 
> I'm fine with all the rest.
> 
> -- 
> Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/