Re: agp/intel: Fix the pre-9xx chipset flush

[Jan Beulich]

Eric,

in this patch you removed from intel_i830_setup_flush() a call to
map_page_into_agp(), but you left in place the counterpart call from
intel_i830_fini_flush() to unmap_page_from_agp()? Isn't it mere luck
that on x86 this is only a call to set_pages_wb()?

Further, is there really a point in doing the respective allocation
with GFP_DMA32? Nor does __GFP_ZERO seem really necessary...

Thanks, Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/