Re: [Discussion] USB: musb-gadget: how to fix ZLP issue in musb_g_tx

From: Sergei Shtylyov
Date: Thu Sep 16 2010 - 07:05:30 EST


Hello.

On 16-09-2010 10:05, Felipe Balbi wrote:

I don't see what to rework. The last short packet should still satisfy
(request->actual == request->length) condition, no?

of course not, it's short not zero. so the last short packet can be
anything from 1 to 511 bytes.

Sigh. Where have I said anything different? What I meant is that the last short packet is already counted in request->actual, otherwise the condition (request->actual & (musb_ep->packet_sz - 1)) wouldn't work.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/