Re: [PATCH] drivers/media/video/ivtv/ivtvfb.c: prevent readinguninitialized stack memory

[Andy Walls]

Acked-by: Andy Walls <awalls@xxxxxxxxxxxxxxxx>

By tomorrow evening I'll put this in my repo and ask for Mauro to pull it.

Regards,
Andy

Dan Rosenberg <drosenberg@xxxxxxxxxxxxx> wrote:

>The FBIOGET_VBLANK device ioctl allows unprivileged users to read 16
>bytes of uninitialized stack memory, because the "reserved" member of
>the fb_vblank struct declared on the stack is not altered or zeroed
>before being copied back to the user.  This patch takes care of it.
>
>Signed-off-by: Dan Rosenberg <dan.j.rosenberg@xxxxxxxxx>
>
>--- linux-2.6.35.4.orig/drivers/media/video/ivtv/ivtvfb.c	2010-08-26 19:47:12.000000000 -0400
>+++ linux-2.6.35.4/drivers/media/video/ivtv/ivtvfb.c	2010-09-15 14:16:46.797375399 -0400
>@@ -458,6 +458,8 @@ static int ivtvfb_ioctl(struct fb_info *
> 			struct fb_vblank vblank;
> 			u32 trace;
> 
>+			memset(&vblank, 0, sizeof(struct fb_vblank));
>+
> 			vblank.flags = FB_VBLANK_HAVE_COUNT |FB_VBLANK_HAVE_VCOUNT |
> 					FB_VBLANK_HAVE_VSYNC;
> 			trace = read_reg(IVTV_REG_DEC_LINE_FIELD) >> 16;
>
>
>
>
èº{.nÇ+‰·Ÿ®‰­†+%ŠËlzwm…ébëæìr¸›zX§»®w¥Š{ayºÊÚë,j­¢f£¢·hš‹àz¹®w¥¢¸¢·¦j:+v‰¨ŠwèjØm¶Ÿÿ¾«‘êçzZ+ƒùšŽŠÝj"ú!¶iO•æ¬z·švØ^¶m§ÿðÃnÆàþY&—