Re: [PATCH -tip -v4] irq_work: generic hard-irq context callbacks

From: Peter Zijlstra
Date: Wed Sep 15 2010 - 11:42:32 EST


On Wed, 2010-09-15 at 17:10 +0200, Andi Kleen wrote:
> > On Wed, 2010-09-15 at 13:29 +0800, Huang Ying wrote:
> >
> >> I uses the cross build tool from:
> >>
> >> http://www.kernel.org/pub/tools/crosstool/
> >
> > I'm not familiar with those, I build my own gcc-4.5.1 toolchains for all
> > targets that would actually build a gcc toolchains, for those that don't
> > I simply don't care about.
>
> I don't think it's a reasonable requirement to have every contributor
> compile on all architectures. If that was a general requirement
> soon nobody would send patches anymore.
>
> Cross arch breakages happen rarely and can be usually repaired after
> the fact.

I think its reasonable to at least try and compile bits if you
explicitly touch these architectures like the patch under consideration
does.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/