Re: [tip:perf/core] hw breakpoints: Fix pid namespace bug

From: Ingo Molnar
Date: Wed Sep 15 2010 - 07:46:25 EST



* Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:

> On Wed, Sep 15, 2010 at 10:03:06AM +0000, tip-bot for Matt Helsley wrote:
> > Commit-ID: d958077d007d98125766d11e82da2fd6497b91d6
> > Gitweb: http://git.kernel.org/tip/d958077d007d98125766d11e82da2fd6497b91d6
> > Author: Matt Helsley <matthltc@xxxxxxxxxx>
> > AuthorDate: Mon, 13 Sep 2010 13:01:18 -0700
> > Committer: Ingo Molnar <mingo@xxxxxxx>
> > CommitDate: Wed, 15 Sep 2010 10:43:59 +0200
> >
> > hw breakpoints: Fix pid namespace bug
> >
> > Hardware breakpoints can't be registered within pid namespaces
> > because tsk->pid is passed rather than the pid in the current
> > namespace.
> >
> > (See https://bugzilla.kernel.org/show_bug.cgi?id=17281 )
> >
> > This is a quick fix demonstrating the problem but is not the
> > best method of solving the problem since passing pids internally
> > is not the best way to avoid pid namespace bugs. Subsequent patches
> > will show a better solution.
> >
> > Much thanks to Frederic Weisbecker <fweisbec@xxxxxxxxx> for doing the
> > bulk of the work finding this bug.
> >
> > Signed-off-by: Matt Helsley <matthltc@xxxxxxxxxx>
> > Signed-off-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> > Cc: Robin Green <greenrd@xxxxxxxxxxx>
> > Cc: Prasad <prasad@xxxxxxxxxxxxxxxxxx>
> > Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> > Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> > Cc: Will Deacon <will.deacon@xxxxxxx>
> > Cc: Mahesh Salgaonkar <mahesh@xxxxxxxxxxxxxxxxxx>
> > LKML-Reference: <f63454af09fb1915717251570423eb9ddd338340.1284407762.git.matthltc@xxxxxxxxxx>
> > Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
> > ---
>
>
> Aiie, you have been too fast too apply that on -tip, [...]

Came from Peter.

> [...] especially it should go to perf/urgent with some stable backport
> tags. And I need to test them as he said that was only compile tested.

No problem, mind cherry-picking it into an urgent pull request? The
overlap is not an issue.

> Lemme just check it really fixes the issue and I'll package his three
> patches in according pull requests.

Ok!

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/