Re: [RESEND/PATCH 5/6] USB: musb-gadget: complete request only ifdata is transfered over

From: Ming Lei
Date: Wed Sep 15 2010 - 06:37:30 EST


2010/9/15 Sergei Shtylyov <sshtylyov@xxxxxxxxxx>:
> On 15.09.2010 14:22, Felipe Balbi wrote:
>
>>> I don't see why we should fix only this problem, while it's obvious tha
>>> the fix is incomplete and leaves the other problem exposed. Please recast
>>> the
>>> patch.
>
>> IMO, the ZLP fix is *another* fix and as such subject to a different
>> patch.
>
>   IMHO, this fix as it is now is quite stupid. It's clear that the check is
> misplaced and will be removed once the ZLP fix is done. So why not do it
> once and for all? Is it so hard to do? FWIW, I NAK this patch as it is now.

Maybe we should open a new thread to discuss the ZLP fix, I'll do it later.

--
Lei Ming
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/