Re: [RESEND/PATCH 5/6] USB: musb-gadget: complete request only ifdata is transfered over

From: Sergei Shtylyov
Date: Wed Sep 15 2010 - 06:10:31 EST


Hello.

On 15-09-2010 14:05, Felipe Balbi wrote:

I didn't say it was duplicate for DMA, just too late.

how come ? we need to send ZLP before giving back the request.

Well, look at the code ionce again. We need to send ZLP *after* request->actual == request->length, but as the check is inserted after the ZLP send, ZLP *may* be sent once the first DMA completes, not the last.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/