Re: linux-next: build warnings after merge of the final tree (tiptreee related)

From: Stephen Rothwell
Date: Wed Sep 15 2010 - 00:39:16 EST


Hi Yinghai,

On Tue, 14 Sep 2010 18:33:34 -0700 Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>
> On 09/14/2010 05:29 PM, Stephen Rothwell wrote:
> >
> > Do not remove the "extern" key word.
>
> why? you got another warning?

It is normal C coding practice to mark declarations in header files with
extern. It probably doesn't strictly matter for functions, but I have
seen a case where not doing so to a variable lead to multiple definitions
of the variable. Consistency is also good.

--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature