Re: [PATCH] hvc_console: fix dropping of characters when outputbyte channel is full

From: Scott Wood
Date: Tue Sep 14 2010 - 16:05:55 EST


On Tue, 14 Sep 2010 20:44:10 +0100
Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:

> > Yes, hvc_push() reschedules. It doesn't sit in a tight loop burning
> > electrons!
> >
> > Can we do something safer&smarter here?
>
>
> Its a printk handler - better to lose the bytes than hang the box. I
> think the current code is probably right.

Losing the bytes is unacceptable. Even if an hvc backend erroneously
returns zero on a permanent error, the timeout should prevent hanging
the box for too long.

Though I suspect the right answer for us may be "don't use the hvc
layer".

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/